Align System Capability Manager Behavior with Java Suite #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Working on making them return with data if subscriptions are not supported as well
* Update subscription status dict
* Added logs
joeljfischer
added
best practice
* Fix swift names of APIs
joeljfischer
changed the title
NicoleYarroch
suggested changes
Feb 10, 2020
* Fix the displaysObserver not being properly generated
* Add tests around non-DISPLAYS subscribed bool for subscriptions with 3 selector parameters
NicoleYarroch
suggested changes
Feb 18, 2020
Co-Authored-By: NicoleYarroch <nicole@livio.io>
…ps://github.com/smartdevicelink/sdl_ios into bugfix/issue-1535-align-systemcapabilitymanager
NicoleYarroch
suggested changes
Feb 19, 2020
NicoleYarroch
approved these changes
Feb 20, 2020
NicoleYarroch
suggested changes
Feb 20, 2020
NicoleYarroch
suggested changes
Feb 20, 2020
NicoleYarroch
approved these changes
Feb 20, 2020
bilal-alsharifi
approved these changes
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1535
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Unit Tests
subscribemethodisCapabilitySupportedmethodCore Tests
Test Obj-C subscribe with 0, 1, 2, and 3 parameters
Test Obj-C subscribe with update handler
Test Obj-C subscribe with block (deprecated)
Test isCapabilitySupported
Check method signatures for Swift
Core version / branch / commit hash / module tested against: Sync Gen 3.2 (18124_DEVTEST), Manticore v.2.4.2 (SDL Core v6.0.1)
HMI name / version / branch / commit hash / module tested against: Sync Gen 3.2 (18124_DEVTEST), Manticore v.2.4.2 (Generic HMI v0.7.2)
Summary
This PR makes additions and some minor behavioral changes to existing system capability manager methods in order to bring behavior into alignment with the Java Suite SCM as much as is reasonable.
Changelog
Enhancements
SystemCapabilityManager.subscribeToCapabilityType:withUpdateHandler:method with more verbose error reporting than the now deprecatedSystemCapabilityManager.subscribeToCapabilityType:withBlock:method.SystemCapabilityManager.subscribeToCapabilityType:withObserver:selector:selector now supports up to three parameters, adding anerrorparameter and booleansubscribedparameter.subscribemethods now immediately return the cached value.isCapabilitySupported:method that can be used to quickly determine if the feature is supported by the head unit or not.Bug Fixes
updateCapabilityType:completionHandler:call or the firstsubscribeto that capability type is made.unsubscribeFromCapabilityType:withObserver:such that no observers remain for that type will now unsubscribe theSystemCapabilityManagerfrom receiving any more data about that type untilupdateCapabilityType:completionHandler:or anothersubscribecall is made for that type.CLA