Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lockscreen storyboard warnings #1530

Merged
merged 2 commits into from Jan 29, 2020
Merged

Lockscreen storyboard warnings #1530

merged 2 commits into from Jan 29, 2020

Conversation

justingluck93
Copy link
Contributor

Fixes #1521

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • [n/a] I have run the unit tests with this PR
  • [n/a] I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

This test only affects how the lock screen is displayed

Summary

Fixed constraints in storyboard. Added the proper class sizes to the constraints.

CLA

@justingluck93 justingluck93 added the bug A defect in the library label Jan 28, 2020
@justingluck93 justingluck93 self-assigned this Jan 28, 2020
@justingluck93 justingluck93 changed the base branch from master to develop January 28, 2020 21:20
joeljfischer
joeljfischer suggested changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@joeljfischer joeljfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. This should target develop, not master.
  2. The landscape constraints are now broken.

@joeljfischer joeljfischer added the manager-lockscreen Relating to the manager layer - lockscreen label Jan 28, 2020
@joeljfischer joeljfischer added this to In progress in v6.6.0 via automation Jan 29, 2020
@joeljfischer joeljfischer merged commit 5fd1925 into develop Jan 29, 2020
v6.6.0 automation moved this from In progress to Done Jan 29, 2020
@joeljfischer joeljfischer deleted the bugfix/issue-1521-LockScreen-Warnings branch January 29, 2020 17:08
@theresalech theresalech mentioned this pull request Jan 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeljfischer joeljfischer joeljfischer approved these changes

Assignees

@justingluck93 justingluck93

Labels
bug A defect in the library manager-lockscreen Relating to the manager layer - lockscreen
Projects
No open projects
v6.6.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@justingluck93 @joeljfischer