Create XM, AM and FM Convenience inits #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justingluck93
changed the title
joeljfischer
suggested changes
Jan 22, 2020
| /// | ||
| /// @param hdChannel Must be between 0 and 7 | ||
| /// @return An instance of the SDLRadioControlData class | ||
| - (instancetype)initAMWithHdChannel:(nullable NSNumber<SDLInt> *)hdChannel; |
There was a problem hiding this comment.
see above comment
joeljfischer
suggested changes
Jan 23, 2020
joeljfischer
added
the
best practice
joeljfischer
approved these changes
Jan 27, 2020
joeljfischer
deleted the
bugfix/issue-1206-SDLRadioControlData-convenience-init
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1206
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
Added unit test to create an SDLRadioControlData and make sure the correct variables are set properly
Core Tests
Tested that the data is set correctly
Core version / branch / commit hash / module tested against: Develop
HMI name / version / branch / commit hash / module tested against: Develop
Summary
Added a few Convenience inits to set data for XM, FM and AM frequency
CLA