Fixing lock screen dismiss call if not being presented.

[kshala-ford]

Fixes #1523

This PR is [ready] for review.

Risk

This PR makes [no] API changes.

Bug Fixes

• Fixes issue where LockScreenWillDismiss notification appears without LockScreenDidDismiss.

Tasks Remaining:

• [Add early return if lock view controller is not presented]
• [Run existing unit tests successfully]

CLA

• I have signed the CLA

[joeljfischer]

Hi @kshala-ford. Unfortunately, I'm having difficulty reproducing this issue. I understand the general idea of it, but I have tested an example video streaming app (the Obj-C example app with AppHMITypeNavigation and insecure autostreaming of a blank UIViewController) on Sync 3.0 and Sync 3.4 and have not been able to reproduce it. syncFrame is seems to be called correctly for me whether I start it without a lock screen, with a lock screen, or change the lock screen.

I'm also having difficulty understanding this statement from the attached issue:

Every dismiss attempt sends a SDLLockScreenManagerWillDismissLockScreenViewController notification. However if the lock screen is not presented, the notification SDLLockScreenManagerDidDismissLockScreenViewController is missing.

Should the second sentence be "the notification SDLLockScreenManagerDidDismissLockScreenViewController should not be sent."?

Could you please clarify the original issue and provide additional reproduction steps?

[joeljfischer]

I was able to reproduce this and test the fix on iOS 12 devices.