Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues shown by OCMock 3.5 #1518

Merged
merged 2 commits into from Jan 8, 2020

Conversation

joeljfischer
Copy link
Contributor

Fixes #1517

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

Unit tests were fixed in places that a mocked object was never used.

Core Tests

n/a, only relates to unit test code

Core version / branch / commit hash / module tested against: n/a
HMI name / version / branch / commit hash / module tested against: n/a

Summary

This PR fixes issues related to OCMock 3.5 and updates testing dependencies.

Changelog

Bug Fixes
  • Updated testing dependencies and fixing test issues related to OCMock 3.5 which causes test failures if a mocked object isn't used.

CLA

@joeljfischer joeljfischer added bug A defect in the library testing Relating to unit testing or smoke testing labels Jan 8, 2020
@joeljfischer joeljfischer self-assigned this Jan 8, 2020
@joeljfischer joeljfischer added this to In progress in v6.5.0 via automation Jan 8, 2020
@NicoleYarroch NicoleYarroch self-requested a review January 8, 2020 19:23
Copy link
Contributor

@NicoleYarroch NicoleYarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment

SmartDeviceLinkTests/ProxySpecs/SDLHapticManagerSpec.m Outdated Show resolved Hide resolved
v6.5.0 automation moved this from In progress to Review in progress Jan 8, 2020
@NicoleYarroch NicoleYarroch self-requested a review January 8, 2020 20:13
v6.5.0 automation moved this from Review in progress to Reviewer approved Jan 8, 2020
@joeljfischer joeljfischer merged commit 2ff8972 into develop Jan 8, 2020
v6.5.0 automation moved this from Reviewer approved to Done Jan 8, 2020
@joeljfischer joeljfischer deleted the bugfix/issue-1517-OCMock-test-failures branch January 8, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library testing Relating to unit testing or smoke testing
Projects
No open projects
v6.5.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants