Only try to remove from run loop when we aren't closing #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* It will be implicitly removed when the stream is closed
NicoleYarroch
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1494
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
No unit tests were added because the change made no changes to unit test results and the bug is not testable via unit tests.
Core Tests
Connected via IAP to a Ford Sync 3 module.
Core version / branch / commit hash / module tested against: Ford Sync 3 - 19317_DEVTEST
HMI name / version / branch / commit hash / module tested against: unknown
Summary
The bug has not been reproducible, therefore this fix is also not reproducible. This PR is for visibility purposes.
Changelog
Bug Fixes
Tasks Remaining:
CLA