Fixed the Show RPC's templateConfiguration parameter not getting set #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeljfischer
approved these changes
Dec 6, 2019
joeljfischer
deleted the
bugfix/issue_1486_show_templateConfiguration_param_not_set
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1486
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
Added unit tests to the
SDLShowSpecCore Tests
This PR does not need to be tested against SDL Core. I verified that the parameter is now being set in the test cases for
SDLShow.Core version / branch / commit hash / module tested against: n/a
HMI name / version / branch / commit hash / module tested against: n/a
Summary
Fixed the
ShowRPC'stemplateConfigurationparameter not getting set.Changelog
Bug Fixes
SDLShow'stemplateConfigurationparameter is now set and retrieved correctly.CLA