Fixed soft button operation never finishing if template does not support soft buttons #1484
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1474
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
SDLSoftButtonReplaceOperationSpec
to check if the operation finishes as expected.Core Tests
Reproduction Steps
LARGE_GRAPHIC_WITH_SOFTBUTTONS
template and use the screen manager to send 8 soft buttons when the template has been set successfully.LARGE_GRAPHIC_ONLY
template and use the screen manager to send 8 new soft buttons when the template has been set successfully. To reproduce the bug, set a break point in theSDLSoftButtonManager
'ssdl_displayCapabilityDidUpdate:
and manually set theSDLSoftButtonReplaceOperation
'scapabilities
tonil
in the console.LARGE_GRAPHIC_WITH_SOFTBUTTONS
template and use the screen manager to send 8 new soft buttons when the template has been set successfully. The new buttons will not be sent.Core version / branch / commit hash / module tested against: sdl_core, commit 4d283e625dfa09d166d572fa7bf6e98e91f05050 (tag: 6.0.0_RC2, origin/release/6.0.0, release/6.0.0)
HMI name / version / branch / commit hash / module tested against: generic_hmi, commit 8fd46298ec636896add85afbea78c550d79fd2b0 (HEAD -> develop, tag: 0.7.0-RC, origin/release/0.7.0)
Summary
Fixed an issue with the soft button
transactionQueue
freezing when a newly set template does not support soft buttons. This was due to the operation not being finished after sending the text only soft buttons successfully.Changelog
Bug Fixes
CLA