New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix apps running iOS 13 multi-window not working correctly with the lock screen #1470
Conversation
* Fix lock screen not appearing on iOS 13
I found an iOS 13 issue with dismissing the lockscreen when the phone is disconnected while the app is in the background. This is not an issue with iOS 12 dismissal code
Expected Result Actual Result |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found one issue. I left a comment on the PR.
The lockscreen would stay active if: * The app was in the foreground and DD was active * The app was backgrounded * The device was disconnected * The app was foregrounded the lock screen would still be active
@NicoleYarroch Fixed |
@NicoleYarroch fixed |
Have not been able to reproduce the original crash (in #1430), but can confirm I do not see any broken behavior with the changes. One small detail - attached is a video and from 0:15-0:20 you can see that the lock screen presents itself and the sort of disappears (originally, It would slide back down). |
Hi Satbir, I saw the video, but it's difficult to discern exactly what is happening. Can you give us additional information on which module / version you were testing against as well as what you were doing when that jitter occurred (e.g. was it when you plugged the device in, or when you were changing the driver distraction state, etc.). |
Hey Joel, |
I believe that may be related to a particular version of Sync. I'm not seeing the behavior on newer versions of Sync nor with Manticore running Core 5.1.0. |
Fixes #1430, #1469
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Summary
This PR makes a few changes to lock screen support especially relating to iOS 13.
[UIApplication sharedApplication].windows[0]
on iOS 13.Changelog
Bug Fixes
CLA