New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish up remaining documentation in iOS library #1466
Merged
joeljfischer
merged 29 commits into
develop
from
feature/issue_983_Remaining_Documentation
Nov 14, 2019
Merged
Finish up remaining documentation in iOS library #1466
joeljfischer
merged 29 commits into
develop
from
feature/issue_983_Remaining_Documentation
Nov 14, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeljfischer
suggested changes
Nov 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review, I want to make sure it doesn't get too big.
joeljfischer
suggested changes
Nov 7, 2019
joeljfischer
suggested changes
Nov 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last set of requested changes
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
joeljfischer
suggested changes
Nov 12, 2019
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
joeljfischer
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #983
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Review documentation
Summary
Added missing documentation to classes, inits, methods, and properties
CLA