Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish up remaining documentation in iOS library #1466

Merged
merged 29 commits into from Nov 14, 2019

Conversation

justingluck93
Copy link
Contributor

@justingluck93 justingluck93 commented Oct 30, 2019

Fixes #983

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

Review documentation

Summary

Added missing documentation to classes, inits, methods, and properties

CLA

@justingluck93 justingluck93 self-assigned this Oct 30, 2019
@joeljfischer joeljfischer added the documentation Relating to inline documentation label Oct 31, 2019
Copy link
Contributor

@joeljfischer joeljfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review, I want to make sure it doesn't get too big.

SmartDeviceLink/NSNumber+NumberType.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLAlertManeuver.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLArtwork.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLArtwork.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLAudioControlCapabilities.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLLogConstants.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLLogConstants.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLLogConstants.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLLogConstants.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLLogFileModule.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLLogFilter.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLManager.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLMenuCell.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLMenuManagerConstants.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLMenuManagerConstants.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLRPCMessageType.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLRPCRequest.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLRPCResponse.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLRPCStruct.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLRPCStruct.h Outdated Show resolved Hide resolved
Copy link
Contributor

@joeljfischer joeljfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last set of requested changes

SmartDeviceLink/SDLProtocolConstants.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLReleaseInteriorVehicleDataModule.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLSISData.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLScreenManager.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLScreenManager.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLSupportedSeat.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLTouch.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLTouch.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLTouchManager.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLVersion.h Outdated Show resolved Hide resolved
justingluck93 and others added 3 commits November 7, 2019 12:57
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
SmartDeviceLink/SDLAudioStreamManager.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLAudioStreamManager.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLAudioStreamManager.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLAudioStreamManager.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLAudioStreamManager.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLManager.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLRPCMessageType.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLVersion.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLVersion.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLVersion.h Outdated Show resolved Hide resolved
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
@joeljfischer joeljfischer merged commit ba3953b into develop Nov 14, 2019
@joeljfischer joeljfischer deleted the feature/issue_983_Remaining_Documentation branch November 14, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Relating to inline documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants