Update styling for iOS 13 #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* But still works on < iOS 13
joeljfischer
added
bug
NicoleYarroch
suggested changes
Oct 24, 2019
| <device id="retina4_7" orientation="portrait"> | ||
| <adaptation id="fullscreen"/> | ||
| </device> | ||
| <document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="15400" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" colorMatched="YES" initialViewController="l5Q-ZP-1BO"> |
There was a problem hiding this comment.
- The dark styling looks good on the Obj-C example app but it isn't applied on the Swift app.
- When I swipe between the TCP and iAP tabs in dark mode, I can see the white background. I think the background should be black as well.
* Fix transitions not being in dark mode
NicoleYarroch
approved these changes
Oct 24, 2019
joeljfischer
deleted the
bugfix/issue-1428-fix-example-app-styling-ios-13-dark-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1428
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Testing performed on an iOS 13 and iOS 10 device
Summary
This PR updates the example app storyboards to use colors that can be adapted automatically on iOS 13.
Changelog
Bug Fixes
CLA