Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wording in warning messages #1458

Merged
merged 1 commit into from Oct 23, 2019

Conversation

joeljfischer
Copy link
Contributor

Fixes #1450

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

No testing needed or performed

Summary

This PR fixes the wording of a few warning logs relating to minimum versions from stating "greater" to "lesser".

Changelog

Bug Fixes
  • Fixed log wording to be correct in minimum version block warning logs.

CLA

@joeljfischer joeljfischer added the bug A defect in the library label Oct 22, 2019
@joeljfischer joeljfischer self-assigned this Oct 22, 2019
@joeljfischer joeljfischer added this to In progress in v6.4 via automation Oct 22, 2019
@NicoleYarroch NicoleYarroch self-requested a review October 23, 2019 12:56
@NicoleYarroch NicoleYarroch added this to the 6.4.0 milestone Oct 23, 2019
v6.4 automation moved this from In progress to Reviewer approved Oct 23, 2019
@joeljfischer joeljfischer merged commit 1572861 into develop Oct 23, 2019
v6.4 automation moved this from Reviewer approved to Done Oct 23, 2019
@joeljfischer joeljfischer deleted the bugfix/issue_1450_warning_message_fix branch October 23, 2019 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library
Projects
No open projects
v6.4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants