Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added payload encrypted description #1452

Merged
merged 3 commits into from Oct 21, 2019
Merged

Added payload encrypted description #1452

merged 3 commits into from Oct 21, 2019

Conversation

NicoleYarroch
Copy link
Contributor

@NicoleYarroch NicoleYarroch commented Oct 18, 2019 •
edited

Fixes #1451

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

Smoke tested

Summary

  • The header of an encrypted payload is now printed in the logs.

Changelog

Enhancements
  • Header of encrypted payload is now printed in logs.
Bug Fixes
  • Fixed Travis issues with CGRect, CGPoint, & CGSize

CLA

@NicoleYarroch
Added payload encrypted description
22f7208 
* Attempted to fix Travis issue with CGRect
@NicoleYarroch NicoleYarroch added the best practice Not a defect but something that should be improved anyway label Oct 18, 2019
@NicoleYarroch NicoleYarroch added this to the 6.4.0 milestone Oct 18, 2019
@NicoleYarroch NicoleYarroch self-assigned this Oct 18, 2019
@NicoleYarroch NicoleYarroch added this to In progress in v6.4 via automation Oct 18, 2019
v6.4 automation moved this from In progress to Reviewer approved Oct 21, 2019
@joeljfischer joeljfischer merged commit 1a61b70 into develop Oct 21, 2019
v6.4 automation moved this from Reviewer approved to Done Oct 21, 2019
@joeljfischer joeljfischer deleted the bugfix/issue_1451_add_better_description_to_encrypted_messages branch October 21, 2019 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeljfischer joeljfischer joeljfischer approved these changes

Assignees

@NicoleYarroch NicoleYarroch

Labels
best practice Not a defect but something that should be improved anyway
Projects
No open projects
v6.4
  
Done
Milestone
6.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NicoleYarroch @joeljfischer