Fix some RemoteControlCapabilities parameters having the wrong type #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix type of `lightControlCapabilities` and `hmiSettingsControlCapabilities` by wrapping in an array
justingluck93
approved these changes
Oct 16, 2019
joeljfischer
deleted the
bugfix/issue-1441-remotecontrolcapabilities-incorrect-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1441
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Unit tests performed
Summary
This PR alters the internals of getting and setting two
RemoteControlCapabilitiesparameters so that what is typed in the sdl_ios library will work with the RPC spec even though they diverge.Changelog
Bug Fixes
SDLRemoteControlCapabilities.lightControlCapabilitiesandSDLRemoteControlCapabilities.hmiSettingsControlCapabilitiesto not crash when getting the parameter from Core, and to properly send the value to Core.CLA