Implement SDL 0179 - Pixel Density and Scale #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amingCapability'.
…nges in the view controller's size to the accepted video resolution divided by the scale.
… Scale' proposal.
…el_density_and_scale
…el_density_and_scale
…deo streaming source match size.
…el_density_and_scale
…from notifications on its own)
…ecycleManager in init #1360 (comment)
#1360 (comment) #1360 (comment) update CarWindow and TouchManager to use scale from StreamingVideoLifecycleManager in init #1360 (comment)
…from notifications on its own)
#1360 (comment) #1360 (comment) update private property of tested class in test to meet its declaration
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
…agerSpec.m Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
…agerSpec.m Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
…agerSpec.m Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
…github.com/smartdevicelink/sdl_ios into feature/issue_1007_pixel_density_and_scale
Changed FocusableItemLocator’s init from streamManager to videoScaleManager
joeljfischer
suggested changes
Oct 9, 2019
SmartDeviceLinkTests/UtilitiesSpecs/Touches/SDLTouchManagerSpec.m
Outdated
Show resolved
Hide resolved
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
joeljfischer
approved these changes
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1007
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Unit tests added for:
Summary
diagonalScreenSize,pixelPerInch, andscale, were added toSDLVideoStreamingCapability.SDLH264VideoEncoder'sdimensionsare now scaled in theSDLStreamingVideoLifecycleManager.SDLCarWindowis now set to the scaled video resolution sent by core in thevideoStreamingCapability.SDLTouchManagernow scales the touch event coordinates returned by core.SDLFocusableItemLocatornow scales the haptic data sent to core.Contributors
Based on PR #1401
Contributors: @lnafarrateluxoft, @yLeonid
CLA