Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a single state soft button object without having to create a stat… #1376

Conversation

joeljfischer
Copy link
Contributor

Fixes #1375

This PR is ready for review.

Risk

This PR makes minor API changes.

Testing Plan

Unit tests added

Summary

This PR adds the ability to create a soft button object in one line by implicitly creating the soft button state.

Changelog

Enhancements
  • Add an API to create a soft button state implicitly while creating the soft button object.

CLA

@joeljfischer joeljfischer added this to the 6.4.0 milestone Aug 7, 2019
@joeljfischer joeljfischer self-assigned this Aug 7, 2019
@joeljfischer joeljfischer added this to In progress in v6.4 via automation Aug 7, 2019
@NicoleYarroch NicoleYarroch self-requested a review August 8, 2019 15:13
@NicoleYarroch
Copy link
Contributor

The SoftButtonObjects transitionToNextState should check states count and return if there is only 1 state. Otherwise the manager "transitions" the button to the same state.

Copy link
Contributor

@NicoleYarroch NicoleYarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 1 comment

v6.4 automation moved this from In progress to Review in progress Aug 8, 2019
v6.4 automation moved this from Review in progress to Reviewer approved Aug 12, 2019
@joeljfischer joeljfischer merged commit fb6f174 into develop Aug 14, 2019
v6.4 automation moved this from Reviewer approved to Done Aug 14, 2019
@joeljfischer joeljfischer deleted the bugfix/issue_1375_softbuttonobject_single_state_initializer branch August 14, 2019 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v6.4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants