Add option to hide device logo in SDLLockScreenViewController #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeljfischer
changed the title
added 5 commits
August 8, 2019 14:19
# Conflicts: # SmartDeviceLink/SDLLockScreenConfiguration.h
joeljfischer
suggested changes
Aug 9, 2019
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
joeljfischer
suggested changes
Aug 13, 2019
added 2 commits
August 13, 2019 13:19
joeljfischer
suggested changes
Aug 13, 2019
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
joeljfischer
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1370
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Run on manticore and set showdevicelogo to false
Summary
Added property to not show vehicle logo
CLA