Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VR-only PICS failing in example apps #1362

Merged
merged 3 commits into from Jul 30, 2019

Conversation

justingluck93
Copy link
Contributor

Fixes #1353

This PR is ready for review.

Risk

This PR makes no API changes.

CLA

@justingluck93 justingluck93 self-assigned this Jul 29, 2019
@justingluck93 justingluck93 changed the base branch from master to develop July 29, 2019 13:56
@NicoleYarroch NicoleYarroch added the bug A defect in the library label Jul 29, 2019
@NicoleYarroch NicoleYarroch added this to In progress in v6.4 via automation Jul 29, 2019
@NicoleYarroch NicoleYarroch added this to the 6.4.0 milestone Jul 29, 2019
v6.4 automation moved this from In progress to Review in progress Jul 29, 2019
Copy link
Contributor

@NicoleYarroch NicoleYarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment

@@ -21,7 +21,8 @@ class PerformInteractionManager: NSObject {
///
/// - Parameter manager: The SDL Manager
func show(from triggerSource: SDLTriggerSource) {
manager.screenManager.presentSearchableChoiceSet(choiceSet, mode: interactionMode(for: triggerSource), with: self)
//manager.screenManager.presentSearchableChoiceSet(choiceSet, mode: interactionMode(for: triggerSource), with: self)
manager.screenManager.present(choiceSet, mode: .voiceRecognitionOnly)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncomment the commented out code and remove current present

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@joeljfischer joeljfischer changed the title Bugfix/issue 1353 vr pics fails Fix VR-only PICS failing in example apps Jul 30, 2019
v6.4 automation moved this from Review in progress to Reviewer approved Jul 30, 2019
@joeljfischer joeljfischer merged commit 272b151 into develop Jul 30, 2019
v6.4 automation moved this from Reviewer approved to Done Jul 30, 2019
@joeljfischer joeljfischer deleted the bugfix/issue-1353-VR-PICS-fails branch July 30, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library
Projects
No open projects
v6.4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants