Fix the Permission Manager sending too many observer updates #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Check that updated permissions actually changed. If they didn't, then exclude them from the update * Add spec test
NicoleYarroch
approved these changes
Jul 30, 2019
joeljfischer
deleted the
bugfix/issue_965_permission_manager_notified_too_often
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #965
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Unit tests have been updated
Summary
OnPermissionChangeis sent with all RPCs, not just the changed RPCs. Therefore theSDLPermissionManagersends observer updates with too many changes on the filters. Now, we will check the observer update against our currently known permissions to see if they actually did change.Changelog
Bug Fixes
SDLPermissionManagernotifying observers of permission changes when things didn't actually change.CLA