Implement SDL-0237 Add Feature to Disable "Video Streaming Backgrounded String" Feature #1357
Conversation
…Backgrounded String" feature'
joeljfischer
changed the title
| /** | ||
| When YES, the StreamingMediaManager will send a black screen with "Video Backgrounded String". Defaults to YES. | ||
| */ | ||
| @property (assign, nonatomic) BOOL showVideoBackgroundDisplay; |
There was a problem hiding this comment.
@t-yoshii After more thought and using this, I think this approach won't work. It does not give apps the ability to modify if they show the background display after connection time, which is necessary to support requirements for all OEMs (some OEMs require the display, and others require that it not be there). I think we'll need to have a proposal revision to change this. Let me know if you'd like me to do it or if you'd like to do it yourself.
There was a problem hiding this comment.
Oh, you mean that the showVideoBackgroundDisplay is set at the initialization of lifecycle managers, however, HU type is known after RAI (later than initialization of lifecycle managers.)?
That's a good point.
I would like to hear your fix plan.
There was a problem hiding this comment.
I have submitted a proposal revision smartdevicelink/sdl_evolution#796
There was a problem hiding this comment.
@joeljfischer
I read your proposal and agree with the change. Thank you.
There was a problem hiding this comment.
Hello @t-yoshii, the proposal revision has been accepted! Would you like to make the changes in this PR, or submit a new PR, or I can submit a PR when I have time.
There was a problem hiding this comment.
@joeljfischer ,
I updated the PR to reflect the revision. Could you please review?
Thanks
Fixes #1304
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
We tested with our internal devboard
Summary
Add an option for app developer to disable the "Video Streaming Backgrounded String (SDL-0118)" feature.
Changelog
Breaking Changes
CLA