Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SDL-0225 Update Published App Services #1349

Merged
merged 7 commits into from Jul 24, 2019
Merged

Implement SDL-0225 Update Published App Services #1349

merged 7 commits into from Jul 24, 2019

Conversation

BrettyWhite
Copy link
Contributor

@BrettyWhite BrettyWhite commented Jul 15, 2019 •
edited by NicoleYarroch

Fixes #1260

This PR is ready for review.

Risk

This PR makes minor API changes.

Testing Plan

  • Smoke testing against Core PR
  • Unit tests

Summary

Implement proposal as defined

Tasks Remaining:

  • Unit tests
  • Smoke Tests

CLA

@BrettyWhite BrettyWhite changed the title WIP: Implement SDL-0225 Update Published App Services Implement SDL-0225 Update Published App Services Jul 16, 2019
@joeljfischer joeljfischer added enhancement proposal Accepted SDL Evolution Proposal labels Jul 17, 2019
@NicoleYarroch NicoleYarroch self-requested a review July 17, 2019 15:15
@NicoleYarroch NicoleYarroch added this to In progress in v6.4 via automation Jul 17, 2019
@NicoleYarroch NicoleYarroch added this to the 6.4.0 milestone Jul 17, 2019
v6.4 automation moved this from In progress to Review in progress Jul 17, 2019
NicoleYarroch
NicoleYarroch suggested changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@NicoleYarroch NicoleYarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested some documentation and getter fixes. Also the SDLRPCFunctionNamesSpec needs a test case for the function name.

SmartDeviceLink/SDLUnpublishAppService.h Show resolved Hide resolved
SmartDeviceLink/SDLUnpublishAppService.h Show resolved Hide resolved
SmartDeviceLink/SDLUnpublishAppService.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLUnpublishAppService.m Outdated Show resolved Hide resolved
SmartDeviceLink/SDLUnpublishAppService.m Outdated Show resolved Hide resolved
SmartDeviceLinkTests/RPCSpecs/RequestSpecs/SDLUnpublishAppServiceSpec.m Outdated Show resolved Hide resolved
v6.4 automation moved this from Review in progress to Reviewer approved Jul 18, 2019
@joeljfischer joeljfischer merged commit 0f8db4f into develop Jul 24, 2019
v6.4 automation moved this from Reviewer approved to Done Jul 24, 2019
@joeljfischer joeljfischer deleted the feature/issue-1260-update-published-app-services branch February 7, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicoleYarroch NicoleYarroch NicoleYarroch approved these changes

Assignees

@BrettyWhite BrettyWhite

Labels
proposal Accepted SDL Evolution Proposal
Projects
No open projects
v6.4
  
Done
Milestone
6.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BrettyWhite @NicoleYarroch @joeljfischer