Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SDL-0177 Alert Icon #1341

Merged
merged 5 commits into from Jul 31, 2019
Merged

Implement SDL-0177 Alert Icon #1341

merged 5 commits into from Jul 31, 2019

Conversation

joeljfischer
Copy link
Contributor

@joeljfischer joeljfischer commented Jul 11, 2019 •
edited

Fixes #995

This PR ready for review.

Risk

This PR makes minor API changes.

Testing Plan

Unit tests and smoke tests

Summary

Implements SDL-0177 Alert Icon.

Changelog

Enhancements
  • Add an Image to Alert, allowing setting an image in an Alert on supported systems.

Tasks Remaining:

  • Test against Core PR when available.

CLA

@joeljfischer joeljfischer added enhancement proposal Accepted SDL Evolution Proposal labels Jul 11, 2019
@joeljfischer joeljfischer added this to the 6.4.0 milestone Jul 11, 2019
@joeljfischer joeljfischer self-assigned this Jul 11, 2019
@joeljfischer joeljfischer added this to In progress in v6.4 via automation Jul 11, 2019
@joeljfischer joeljfischer changed the title WIP: Implement SDL-0177 Alert Icon Implement SDL-0177 Alert Icon Jul 29, 2019
justingluck93
justingluck93 suggested changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@justingluck93 justingluck93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small things

Example Apps/Example ObjC/ButtonManager.m Outdated Show resolved Hide resolved
Example Apps/Example ObjC/AlertManager.m Show resolved Hide resolved
Example Apps/Example Swift/AlertManager.swift Show resolved Hide resolved
SmartDeviceLinkTests/RPCSpecs/RequestSpecs/SDLAlertSpec.m Outdated Show resolved Hide resolved
SmartDeviceLinkTests/RPCSpecs/RequestSpecs/SDLAlertSpec.m Outdated Show resolved Hide resolved
v6.4 automation moved this from In progress to Review in progress Jul 31, 2019
joeljfischer and others added 2 commits July 31, 2019 12:58
@joeljfischer @justingluck93
Fix artwork name not being used in the example app
6b89694 
Co-Authored-By: justingluck93 <47197545+justingluck93@users.noreply.github.com>
@joeljfischer
Review fixes
ce66fa5
v6.4 automation moved this from Review in progress to Reviewer approved Jul 31, 2019
@joeljfischer joeljfischer merged commit 105de90 into develop Jul 31, 2019
v6.4 automation moved this from Reviewer approved to Done Jul 31, 2019
@joeljfischer joeljfischer deleted the feature/issue-995-alert-icon branch July 31, 2019 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justingluck93 justingluck93 justingluck93 approved these changes

Assignees

@joeljfischer joeljfischer

Labels
proposal Accepted SDL Evolution Proposal
Projects
No open projects
v6.4
  
Done
Milestone
6.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joeljfischer @justingluck93