Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SDL-0186 Template Titles #1340

Merged
merged 5 commits into from Jul 31, 2019

Conversation

joeljfischer
Copy link
Contributor

@joeljfischer joeljfischer commented Jul 11, 2019

Fixes #1031

This PR is ready for review.

Risk

This PR makes minor API changes.

Testing Plan

Unit tests updated and smoke tests performed

Summary

Adds the ability to set a title text field in Show that declares the title of the screen the user is on.

Changelog

Enhancements
  • Implement SDL-0186 to set a title for the current screen the user is on.

Tasks Remaining:

  • Smoke test against Core PR.

CLA

@joeljfischer joeljfischer added enhancement proposal Accepted SDL Evolution Proposal labels Jul 11, 2019
@joeljfischer joeljfischer added this to the 6.4.0 milestone Jul 11, 2019
@joeljfischer joeljfischer self-assigned this Jul 11, 2019
@joeljfischer joeljfischer added this to In progress in v6.4 via automation Jul 11, 2019
@joeljfischer joeljfischer changed the title WIP: Implement SDL-0186 Template Titles Implement SDL-0186 Template Titles Jul 30, 2019
@NicoleYarroch NicoleYarroch self-requested a review July 31, 2019 13:36
v6.4 automation moved this from In progress to Review in progress Jul 31, 2019
Copy link
Contributor

@NicoleYarroch NicoleYarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the templateTitle TextFieldName

SmartDeviceLink/SDLShow.h Show resolved Hide resolved
v6.4 automation moved this from Review in progress to Reviewer approved Jul 31, 2019
@joeljfischer joeljfischer merged commit 8e5c370 into develop Jul 31, 2019
v6.4 automation moved this from Reviewer approved to Done Jul 31, 2019
@joeljfischer joeljfischer deleted the feature/issue_1031_template_titles branch July 31, 2019 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Accepted SDL Evolution Proposal
Projects
No open projects
v6.4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants