Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New RPC CloseApplication #1337

Merged
merged 5 commits into from Jul 11, 2019
Merged

New RPC CloseApplication #1337

merged 5 commits into from Jul 11, 2019

Conversation

NicoleYarroch
Copy link
Contributor

@NicoleYarroch NicoleYarroch commented Jul 10, 2019 •
edited by joeljfischer

Fixes #801

This PR is ready for review.

Risk

This PR makes minor API changes.

Testing Plan

Smoke tests added for the CloseApplication response and request classes.

Summary

Added CloseApplication request and response classes to the library.

Changelog

Enhancements
  • Added new RPC CloseApplication to the library.

Tasks Remaining:

  • Test against sdl_core v.6.0
  • Set the finalized functionID for CloseApplication

CLA

@NicoleYarroch NicoleYarroch self-assigned this Jul 10, 2019
@NicoleYarroch NicoleYarroch added enhancement proposal Accepted SDL Evolution Proposal labels Jul 10, 2019
@NicoleYarroch NicoleYarroch added this to In progress in v6.4 via automation Jul 10, 2019
@NicoleYarroch NicoleYarroch added this to the 6.4.0 milestone Jul 10, 2019
@NicoleYarroch NicoleYarroch changed the title WIP: New RPC CloseApplication New RPC CloseApplication Jul 10, 2019
v6.4 automation moved this from In progress to Reviewer approved Jul 11, 2019
@joeljfischer joeljfischer merged commit c819c43 into develop Jul 11, 2019
v6.4 automation moved this from Reviewer approved to Done Jul 11, 2019
@joeljfischer joeljfischer deleted the feature/issue_801_close_application_RPC branch July 11, 2019 17:15
@theresalech theresalech mentioned this pull request Jul 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeljfischer joeljfischer joeljfischer approved these changes

Assignees

@NicoleYarroch NicoleYarroch

Labels
proposal Accepted SDL Evolution Proposal
Projects
No open projects
v6.4
  
Done
Milestone
6.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NicoleYarroch @joeljfischer