Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SDL-0223 Add Currently Playing Media Image to MediaServiceData #1328

Merged
merged 4 commits into from Jul 30, 2019
Merged

Implement SDL-0223 Add Currently Playing Media Image to MediaServiceData #1328

merged 4 commits into from Jul 30, 2019

Conversation

justingluck93
Copy link
Contributor

@justingluck93 justingluck93 commented Jul 8, 2019 •
edited

Fixes #1247

This PR is [ready] for review.

Risk

This PR makes [minor] API changes.

Summary

Added an image parameter to the data

CLA

@NicoleYarroch NicoleYarroch added this to In progress in v6.4 via automation Jul 9, 2019
@NicoleYarroch NicoleYarroch added this to the 6.4.0 milestone Jul 9, 2019
@justingluck93 justingluck93 changed the base branch from master to develop July 9, 2019 17:26
v6.4 automation moved this from In progress to Review in progress Jul 9, 2019
NicoleYarroch
NicoleYarroch suggested changes Jul 9, 2019
View reviewed changes
Copy link
Contributor

@NicoleYarroch NicoleYarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment about deprecating the old init

SmartDeviceLink/SDLMediaServiceData.h Show resolved Hide resolved
NicoleYarroch
NicoleYarroch suggested changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@NicoleYarroch NicoleYarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against sdl_core's develop branch and it works. I left a comment about adding another test case.

SmartDeviceLinkTests/RPCSpecs/StructSpecs/SDLMediaServiceDataSpec.m Show resolved Hide resolved
NicoleYarroch
NicoleYarroch suggested changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@NicoleYarroch NicoleYarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the old init add a check to make sure the mediaImage is null

SmartDeviceLinkTests/RPCSpecs/StructSpecs/SDLMediaServiceDataSpec.m Show resolved Hide resolved
v6.4 automation moved this from Review in progress to Reviewer approved Jul 11, 2019
@joeljfischer joeljfischer changed the title adding image to MediaService Data Implement SDL-0223 Add Currently Playing Media Image to MediaServiceData Jul 15, 2019
@joeljfischer joeljfischer merged commit 0681d7e into develop Jul 30, 2019
v6.4 automation moved this from Reviewer approved to Done Jul 30, 2019
@joeljfischer joeljfischer deleted the feature/1247-Add-CPMI-MediaServiceData branch February 7, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicoleYarroch NicoleYarroch NicoleYarroch approved these changes

Assignees

@justingluck93 justingluck93

Labels
None yet
Projects
No open projects
v6.4
  
Done
Milestone
6.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justingluck93 @NicoleYarroch @joeljfischer