Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nil check of eaSession at SDLIAPDataSession#startSession #1322

Conversation

t-yoshii
Copy link

Fixes #1321

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

We have tested with our devboard.

Summary

Add nil check to avoid a crash by assertion.

Changelog

Bug Fixes
  • Fix crash when EA session creation failed

CLA

@joeljfischer joeljfischer added the bug A defect in the library label Jun 26, 2019
@NicoleYarroch NicoleYarroch self-requested a review June 26, 2019 13:33
@NicoleYarroch NicoleYarroch added this to In progress in v6.3 via automation Jun 26, 2019
@NicoleYarroch NicoleYarroch added this to the 6.3.0 milestone Jun 26, 2019
v6.3 automation moved this from In progress to Reviewer approved Jun 26, 2019
@joeljfischer joeljfischer merged commit 7fa2820 into smartdevicelink:develop Jun 26, 2019
v6.3 automation moved this from Reviewer approved to Done Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library
Projects
No open projects
v6.3
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants