Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Pushing a PCM Audio Data Buffer on SDLAudioStreamManager #1289

Merged
merged 7 commits into from Jun 5, 2019
Merged

Support Pushing a PCM Audio Data Buffer on SDLAudioStreamManager #1289

merged 7 commits into from Jun 5, 2019

Conversation

joeljfischer
Copy link
Contributor

@joeljfischer joeljfischer commented May 30, 2019 •
edited

Fixes #1275

This PR is ready for review.

Risk

This PR makes minor API changes.

Testing Plan

Unit tests will be updated

Summary

This PR adds support for RAW PCM audio buffers within the SDLAudioStreamManager.

Changelog

Enhancements
  • Support raw audio stream buffers within the SDLAudioStreamManager.

CLA

@joeljfischer joeljfischer added enhancement proposal Accepted SDL Evolution Proposal labels May 30, 2019
@joeljfischer joeljfischer added this to the 6.3.0 milestone May 30, 2019
@joeljfischer joeljfischer added this to In progress in v6.3 via automation May 30, 2019
@joeljfischer joeljfischer changed the title WIP: Support Pushing a PCM Audio Data Buffer on SDLAudioStreamManager Support Pushing a PCM Audio Data Buffer on SDLAudioStreamManager May 31, 2019
@joeljfischer joeljfischer self-assigned this May 31, 2019
NicoleYarroch
NicoleYarroch suggested changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@NicoleYarroch NicoleYarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the SDLStreamingAudioLifecycleManager should we deprecate the public sendAudioData: method in favor of the audioManager's pushWithData: method?

SmartDeviceLink/SDLAudioStreamManager.h Show resolved Hide resolved
v6.3 automation moved this from In progress to Review in progress Jun 5, 2019
v6.3 automation moved this from Review in progress to Reviewer approved Jun 5, 2019
@joeljfischer joeljfischer merged commit 762a058 into develop Jun 5, 2019
v6.3 automation moved this from Reviewer approved to Done Jun 5, 2019
@joeljfischer joeljfischer deleted the feature/issue_1275_audiostreammanager_push_data_buffer branch June 5, 2019 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicoleYarroch NicoleYarroch NicoleYarroch approved these changes

Assignees

@joeljfischer joeljfischer

Labels
proposal Accepted SDL Evolution Proposal
Projects
No open projects
v6.3
  
Done
Milestone
6.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joeljfischer @NicoleYarroch