Dynamically Update Menu Manager Cells #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
May 14, 2019 10:47
…smarter using less RPC commands, built basic structure in manager to run the loops
…ubcells as a factor in the hash
…e where function was returning an NSArray instead of NSMutableArray
…ut code bit of whitespace cleanup
…es and started to make tests
… update add commands to only add cells at index
…ed but we keep some cells
…/add commands for every sub cell
…d new keeps for subcells to keep the indexs matching
joeljfischer
changed the title
joeljfischer
suggested changes
May 29, 2019
added 7 commits
May 30, 2019 12:40
Rename some files added more unit tests fixed syntax Moved enums to a public file changed function names to align more with the standards
removed setter updated unit tests removed fit
joeljfischer
suggested changes
May 31, 2019
joeljfischer
suggested changes
Jun 10, 2019
joeljfischer
suggested changes
Jun 10, 2019
SmartDeviceLink/SDLMenuManager.m
Outdated
| e.g. If the new menu array is [A, B, C, D] but only [C, D] are new we need to pass [A, B , C , D] so C and D can be added to index 2 and 3 respectively. | ||
| @return list of SDLRPCRequest addCommands | ||
| */ | ||
| - (NSArray<SDLRPCRequest *> *)sdl_mainMenuCommandsForCells:(NSArray<SDLMenuCell *> *)cells withArtwork:(BOOL)shouldHaveArtwork usingIndexOf:(NSArray<SDLMenuCell *> *)menu { |
There was a problem hiding this comment.
Change usingIndexOf: to usingIndexesFrom:? Is that more accurate?
joeljfischer
approved these changes
Jun 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1144
This PR is [ready] for review.
Risk
This PR makes [minor] API changes.
Testing Plan
Unit tests have been created to test dynamic and non dynamic menu manger updates.
Summary
This PR makes the menu manager more efficient when creating a new menu. The menu manger will now compare the old and new menu to find cells to keep. This will reduce the number of Add and delete RPCs. A flag has been added to either use Dynamic menu manger or not. 'dynamicMenuUpdatesMode` this flag can be set using the screen manger.
CLA