Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwiftPM/Accio Support #1273

Merged
merged 14 commits into from May 28, 2019
Merged

SwiftPM/Accio Support #1273

merged 14 commits into from May 28, 2019

Conversation

justingluck93
Copy link
Contributor

@justingluck93 justingluck93 commented May 21, 2019

Fixes #1229

This PR is [ready] for review.

Risk

This PR makes [no] API changes.

Testing Plan

Follow this guide https://github.com/JamitLabs/Accio to get started installing and setting up a new project with Accio

Summary

This change adds support for users to use Accio as a dependency manager in their application.

CLA

Example Package

// swift-tools-version:5.0
import PackageDescription

let package = Package(
    name: "Demo",
    products: [],
    dependencies: [
       .package(url: "https://github.com/smartdevicelink/sdl_ios.git", .branch("feature/issue-1229-SwiftPM")),
    ],
    targets: [
        .target(
            name: "Demo",
            dependencies: [
                "SmartDeviceLinkSwift"
            ],
            path: "Demo"
        ),
    ]
)

@justingluck93 justingluck93 marked this pull request as ready for review May 21, 2019 18:26
Package.swift Outdated
import PackageDescription

let package = Package(
name: "SmartDeviceLink-iOS",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be SmartDeviceLink

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

@joeljfischer joeljfischer added the distribution Relating to distribution of the library to developers label May 28, 2019
@joeljfischer joeljfischer merged commit 9824b27 into develop May 28, 2019
@joeljfischer joeljfischer deleted the feature/issue-1229-SwiftPM branch May 28, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distribution Relating to distribution of the library to developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants