Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all crashes due to lockscreen being setup before app window #1259

Merged
merged 1 commit into from May 13, 2019

Conversation

joeljfischer
Copy link
Contributor

@joeljfischer joeljfischer commented May 9, 2019

Fixes #1258

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

Smoke tests

Original Bug Testing
  1. Ensure that if a VC is locked to an orientation, the status bar remains fixed when the device is rotated.
Crash testing
  1. App window and root vc are setup, then SDL is setup (standard case if you’re using storyboards, etc.)
  2. App window exists but root vc is not setup, then SDL is setup
  3. SDL is setup, then app window / root VC is setup
  4. (3) but done in the background due to SDL connection, then app is brought to the foreground

Summary

This PR fixes all issues related to the lockscreen being setup before the app window. The previous fix for this issue masked one issue, but there was a second issue as well. This fix should prevent developers from needing to make any change in their code, no matter how their app window is setup.

Changelog

Bug Fixes
  • Fix crashes if the app window is setup after SDL.

CLA

@joeljfischer joeljfischer added the bug A defect in the library label May 9, 2019
@joeljfischer joeljfischer self-assigned this May 9, 2019
@joeljfischer joeljfischer merged commit 2318259 into develop May 13, 2019
@joeljfischer joeljfischer deleted the bugfix/issue_1258_lockscreen_crash_2 branch May 13, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants