Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an exception if SDL is setup before the app's root view controller #1256

Merged
merged 2 commits into from May 8, 2019

Conversation

joeljfischer
Copy link
Contributor

Fixes #1255

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

Smoke tests performed

Summary

Throw an exception with detailed information if the lock screen is setup before the app’s window.

Changelog

Bug Fixes
  • If SDL is setup before the app's window and root view controller, fix an infinite recursion crash by throwing our own exception with detailed information on how to fix it.

CLA

@joeljfischer joeljfischer added the bug A defect in the library label May 8, 2019
@joeljfischer joeljfischer self-assigned this May 8, 2019
Copy link
Contributor

@NicoleYarroch NicoleYarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment

@joeljfischer joeljfischer merged commit 96217ad into master May 8, 2019
@joeljfischer joeljfischer deleted the bugfix/issue_1255_lockscreen_crash branch May 8, 2019 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v6.2.1 Causes Infinite Recursion if the App's Window is Setup after SDL
2 participants