Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SDL-0108 - AutoComplete List #1019

Merged
merged 10 commits into from Jul 30, 2019

Conversation

joeljfischer
Copy link
Contributor

@joeljfischer joeljfischer commented Jul 5, 2018

Fixes #790

This PR is ready for review.

Risk

This PR makes minor API changes.

Testing Plan

Unit tests have been updated

Summary

Implements SDL-0108 to enable a list of autocomplete suggestions in the perform interaction keyboard.

Changelog

Enhancements
  • Keyboard used in Perform Interactions / the Screen Manager (searchable choice sets and keyboards) can now display a list of autocompletion suggestion options (SDL-0108).

Tasks Remaining:

  • Test against Core 6.0

CLA

* Added AutoCompleteList to KeyboardProperties
* Updated ChoiceSetManager to handle AutoCompleteList
* Updated Tests
@joeljfischer joeljfischer added enhancement proposal Accepted SDL Evolution Proposal labels Jul 5, 2018
@joeljfischer joeljfischer added this to the 6.1.0 milestone Jul 5, 2018
@joeljfischer joeljfischer self-assigned this Jul 5, 2018
@NicoleYarroch NicoleYarroch removed this from the 6.1.0 milestone Sep 20, 2018
@NicoleYarroch NicoleYarroch changed the title Implement SDL-0108 - AutoComplete List WIP: Implement SDL-0108 - AutoComplete List Jan 16, 2019
@NicoleYarroch
Copy link
Contributor

This PR has been removed from Core 5.0.0 (and therefore 6.1.0). This PR will remain open for the time being, but is not targeted for a specific release.

@theresalech theresalech added this to In progress in v6.4 via automation Jun 13, 2019
@joeljfischer joeljfischer changed the title WIP: Implement SDL-0108 - AutoComplete List Implement SDL-0108 - AutoComplete List Jul 10, 2019
@NicoleYarroch NicoleYarroch added this to the 6.4.0 milestone Jul 11, 2019
Copy link
Contributor

@NicoleYarroch NicoleYarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

SmartDeviceLink/SDLKeyboardDelegate.h Show resolved Hide resolved
SmartDeviceLink/SDLPresentChoiceSetOperation.m Outdated Show resolved Hide resolved
SmartDeviceLink/SDLPresentKeyboardOperation.m Outdated Show resolved Hide resolved
SmartDeviceLink/SDLKeyboardProperties.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLKeyboardDelegate.h Show resolved Hide resolved
v6.4 automation moved this from In progress to Review in progress Jul 11, 2019
Copy link
Contributor

@NicoleYarroch NicoleYarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

SmartDeviceLink/SDLPresentChoiceSetOperation.m Outdated Show resolved Hide resolved
SmartDeviceLink/SDLPresentKeyboardOperation.m Outdated Show resolved Hide resolved
v6.4 automation moved this from Review in progress to Reviewer approved Jul 30, 2019
@joeljfischer joeljfischer merged commit d388eed into develop Jul 30, 2019
v6.4 automation moved this from Reviewer approved to Done Jul 30, 2019
@joeljfischer joeljfischer deleted the feature/issue_790_autocompletelist branch July 30, 2019 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Accepted SDL Evolution Proposal
Projects
No open projects
v6.4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants