Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert deprecations for RPCs to/from NSDictionary #1557

Closed
joeljfischer opened this issue Feb 17, 2020 · 1 comment
Closed

Revert deprecations for RPCs to/from NSDictionary #1557

joeljfischer opened this issue Feb 17, 2020 · 1 comment
Assignees
@joeljfischer
Labels
best practice Not a defect but something that should be improved anyway rpc Relating to the RPC layer
Projects
v6.6.0

Comments

@joeljfischer
Copy link
Contributor

Bug Report

We received a request to remove the deprecation of RPC initWithDictionary and serializeToDictionary because the functionality is being used in production to support archiving RPCs to disk. Because we have a valid use-case, we should remove the deprecation tags.
@joeljfischer joeljfischer added best practice Not a defect but something that should be improved anyway rpc Relating to the RPC layer labels Feb 17, 2020
@joeljfischer joeljfischer mentioned this issue Feb 18, 2020
Merged
4 tasks
@NicoleYarroch
Copy link
Contributor

Fixed in PR #1558

@NicoleYarroch NicoleYarroch added this to Done in v6.6.0 via automation Feb 26, 2020
@joeljfischer joeljfischer mentioned this issue Apr 29, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joeljfischer joeljfischer

Labels
best practice Not a defect but something that should be improved anyway rpc Relating to the RPC layer
Projects
No open projects
v6.6.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joeljfischer @NicoleYarroch