Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDLTouch to handle NSNull occurence #1534

Closed
kshala-ford opened this issue Jan 29, 2020 · 0 comments
Closed

Update SDLTouch to handle NSNull occurence #1534

kshala-ford opened this issue Jan 29, 2020 · 0 comments
Labels
bug A defect in the library manager-streaming-video Relating to the manager layer - video streaming
Projects

Comments

@kshala-ford
Copy link
Contributor

Bug Report

Previously before implementing SDL-0219 the class SDLTouch included a check for touch timestamp array if it contains NSNull. Now the dictionary store returns nil instead of the raw value. There are no real repro steps to reproduce 100%. We did see this issue occurring on older devices after upgrading to the new library version. We also experience that it's easier to reproduce on Ford TDKs.

The issue should be fixed by changing touch to read if the dict store returns nil. Additionally for the time of testing the app the nav app developers would need to disable assertions in the log config.

Reproduction Steps
  1. Use a navigation projection app with sdl_ios 6.5.0
  2. Power up the Ford TDK
  3. Connect the iPhone over USB
  4. Start the navigation app
  5. Try to tap or pan the map of the nav app
Expected Behavior
  • The touch input should be received by the touch manager
  • The app should react on the touch gestures
Observed Behavior
  • Any touch action isn't applied to the app (e.g. maps are not moving)
    Logs are showing

fault RPC com.sdl.log 14:01:56.324393+0100 NavApp Retrieving array from store error: Requested NSNumber but returned NSNull
default 14:01:56.324475+0100 NavApp *** Assertion failure in -[SDLLogManager logAssertWithTimestamp:file:functionName:line:queue:formatMessage:], /Users/kshala/Documents/Sourcetree/github.com/sdl_ios/SmartDeviceLink/SDLLogManager.m:144
error Proxy com.sdl.log 14:01:56.324599+0100 NavApp Proxy: Failed to handle protocol message SDL ASSERTION: Retrieving array from store error: Requested NSNumber but returned NSNull. To disable these assertions, alter your SDLLogConfiguration and set disableAssertions to YES

OS & Version Information
  • iOS Version: Tested on 13.3 but the issue should be iOS independent
  • SDL iOS Version: 6.5.0
  • Testing Against: Test navigation app / Ford SYNC3 v3.0, v3.3 and v3.4
@NicoleYarroch NicoleYarroch added the bug A defect in the library label Jan 29, 2020
@joeljfischer joeljfischer added the manager-streaming-video Relating to the manager layer - video streaming label Jan 29, 2020
@joeljfischer joeljfischer added this to Done in v6.6.0 via automation Feb 24, 2020
@joeljfischer joeljfischer mentioned this issue Apr 29, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library manager-streaming-video Relating to the manager layer - video streaming
Projects
No open projects
v6.6.0
  
Done
Development

No branches or pull requests

3 participants