Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better description to encrypted protocol messages #1451

Closed
NicoleYarroch opened this issue Oct 18, 2019 · 0 comments
Closed

Add better description to encrypted protocol messages #1451

NicoleYarroch opened this issue Oct 18, 2019 · 0 comments
Assignees
Labels
best practice Not a defect but something that should be improved anyway
Projects
Milestone

Comments

@NicoleYarroch
Copy link
Contributor

Bug Report

Add better description to encrypted protocol messages. Currently the description prints:

Sending protocol message: Encrypted header, description overflows

But this is inaccurate because the header itself is not encrypted. Instead the header should be printed with a message saying that a description of the payload can not be printed because it is encrypted.

A better description would be

Sending protocol message: Version:5, encrypted:1, frameType:Single(1), serviceType:11, frameData:Reserved(0), sessionID:1, dataSize:237, messageID:147, Payload is encrypted - no description can be provided

Reproduction Steps
  1. Connect a video streaming app configured to stream encrypted video to sdl_core
  2. Check debug logs
Expected Behavior

The header should be printed for the protocol message.

Observed Behavior

The header is not printed for the protocol message.

OS & Version Information
  • iOS Version: n/a
  • SDL iOS Version: 6.3
  • Testing Against: n/a
@NicoleYarroch NicoleYarroch self-assigned this Oct 18, 2019
@NicoleYarroch NicoleYarroch added the best practice Not a defect but something that should be improved anyway label Oct 18, 2019
@NicoleYarroch NicoleYarroch added this to To do in v6.4 via automation Oct 18, 2019
@NicoleYarroch NicoleYarroch added this to the 6.4.0 milestone Oct 18, 2019
v6.4 automation moved this from To do to Done Oct 21, 2019
@joeljfischer joeljfischer mentioned this issue Oct 24, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
best practice Not a defect but something that should be improved anyway
Projects
No open projects
v6.4
  
Done
Development

No branches or pull requests

2 participants