Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example apps crash if the stop method is called when the lifecycle manager errors #1268

Closed
NicoleYarroch opened this issue May 17, 2019 · 1 comment
Labels
best practice Not a defect but something that should be improved anyway bug A defect in the library example app Relating to the built-in example apps
Projects
Milestone

Comments

@NicoleYarroch
Copy link
Contributor

NicoleYarroch commented May 17, 2019

Bug Report

If the start:readyHandler method errors, the app crashes because it attempts to stop the manager on the same queue, which causes deadlock.

The example app should follow the library's documentation and only stop the manager on the main thread. (#1213)

The app errors out when:

  1. If the RegisterAppInterface fails with a result code of DISALLOWED, the example apps in the library (Swift and Obj-C) crash.
  2. The RegisterAppInterface fails because the session terminated. Failed to register the app. Error: Error Domain=com.sdl.lifecyclemanager.error Code=-2 "Could not find a connection". This happens when the USB cord is pulled after sending a RAI request but before a response is received.
Reproduction Steps for error 1
  1. Create two SDL apps (A and B) using the same app name and app id.
  2. Install both apps on the phone and connect phone to TDK
  3. One app's RegisterAppInterface request will fail with a resultCode of APPLICATION_REGISTERED_ALREADY
Expected Behavior

The device app does not crash.

Observed Behavior

The device app crashes

OS & Version Information
  • iOS Version: n/a
  • SDL iOS Version: 6.2
  • Testing Against: SYNC 3 TDK
@NicoleYarroch NicoleYarroch added bug A defect in the library best practice Not a defect but something that should be improved anyway example app Relating to the built-in example apps labels May 17, 2019
@NicoleYarroch NicoleYarroch changed the title Example apps crash if the RAI fails with DISALLOWED Example apps crash if the stop method is called when the lifecycle manager errors May 20, 2019
@NicoleYarroch
Copy link
Contributor Author

Closed via PR #1248

@theresalech theresalech added this to To do in v6.3 via automation Jun 5, 2019
@theresalech theresalech added this to the 6.3.0 milestone Jun 5, 2019
@theresalech theresalech moved this from To do to Done in v6.3 Jun 5, 2019
@joeljfischer joeljfischer mentioned this issue Jun 24, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
best practice Not a defect but something that should be improved anyway bug A defect in the library example app Relating to the built-in example apps
Projects
No open projects
v6.3
  
Done
Development

No branches or pull requests

2 participants