Moved dealloc to BackgroundTaskManager

* cleaned up some documentation

SmartDeviceLink/SDLBackgroundTaskManager.h

@@ -11,12 +11,15 @@
 
 NS_ASSUME_NONNULL_BEGIN
 
+/**
+ * Class for managing a background task. 
+ */
 @interface SDLBackgroundTaskManager : NSObject
 
 - (instancetype)init NS_UNAVAILABLE;
 
 /**
- *  Convenience init for starting a background task with a specific name
+ *  Convenience init for starting a background task with a specific name.
  *
  *  @param backgroundTaskName  The name for the background task
  *  @return                    A SDLBackgroundTaskManager object
@@ -31,8 +34,8 @@ NS_ASSUME_NONNULL_BEGIN
 /**
  *  Cleans up a background task when it is stopped. This should be called when:
  *
- *  1. The app has established a session
- *  2. The system has called the `expirationHandler` for the background task. The system may kill the app if the background task is not ended.
+ *  1. The app has established a session.
+ *  2. The system has called the `expirationHandler` for the background task. The system may kill the app if the background task is not ended when `expirationHandler` is called.
  */
 - (void)endBackgroundTask;
 

SmartDeviceLink/SDLBackgroundTaskManager.m

@@ -59,6 +59,10 @@ - (void)endBackgroundTask {
     self.currentBackgroundTaskId = UIBackgroundTaskInvalid;
 }
 
+- (void)dealloc {
+    [self endBackgroundTask];
+}
+
 @end
 
 NS_ASSUME_NONNULL_END

SmartDeviceLink/SDLLifecycleManager.m

@@ -213,7 +213,7 @@ - (SDLState *)lifecycleState {
 }
 
 - (void)didEnterStateStarted {
-    // start a background task so a session can be established even when the app is backgrounded.
+    // Start a background task so a session can be established even when the app is backgrounded.
     [self.backgroundTaskManager startBackgroundTask];
 
     // Start up the internal proxy object
@@ -233,7 +233,7 @@ - (void)didEnterStateStarted {
         self.proxy = [SDLProxy iapProxyWithListener:self.notificationDispatcher
                           secondaryTransportManager:self.secondaryTransportManager];
     }
-#   pragma clang diagnostic pop
+    #pragma clang diagnostic pop
 }
 
 - (void)didEnterStateStopped {
@@ -843,12 +843,6 @@ - (void)videoServiceProtocolDidUpdateFromOldProtocol:(nullable SDLProtocol *)old
     }
 }
 
-#pragma mark - Lifecycle Destruction
-
-- (void)dealloc {
-    [self.backgroundTaskManager endBackgroundTask];
-}
-
 @end
 
 NS_ASSUME_NONNULL_END