Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a mechanism to avoid Deadlock #961

Merged
merged 17 commits into from Apr 22, 2020
Merged

Add a mechanism to avoid Deadlock #961

merged 17 commits into from Apr 22, 2020

Conversation

Yuki-Shoda-Nexty
Copy link
Contributor

@Yuki-Shoda-Nexty Yuki-Shoda-Nexty commented Mar 10, 2020 •
edited

This proposal is to avoid deadlock by adding a mechanism that stops AudioStreaming under certain conditions when the app on Handset(HS) side moves to background.

@Yuki-Shoda-Nexty
Copy link
Contributor Author

Hi @theresalech -san
Please review my proposal, thanks!

theresalech
theresalech requested changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@theresalech theresalech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Yuki-Shoda - I've left some comments for your review. Please let me know if you have any questions or concerns with addressing. Additionally, please update the description of your PR to only include the introduction from your proposal:

This proposal is to avoid deadlock by adding a mechanism that stops Audio Streaming under certain conditions when the app on HS side moves to background.

Thank you!

proposals/NNNN-Avoid-Deadlock.md Outdated Show resolved Hide resolved
proposals/NNNN-Avoid-Deadlock.md Outdated Show resolved Hide resolved
proposals/NNNN-Avoid-Deadlock.md Outdated Show resolved Hide resolved
proposals/NNNN-Avoid-Deadlock.md Outdated Show resolved Hide resolved
proposals/NNNN-Avoid-Deadlock.md Outdated Show resolved Hide resolved
proposals/NNNN-Avoid-Deadlock.md Outdated Show resolved Hide resolved
proposals/NNNN-Avoid-Deadlock.md Outdated Show resolved Hide resolved
proposals/NNNN-Avoid-Deadlock.md Outdated Show resolved Hide resolved
proposals/NNNN-Avoid-Deadlock.md Outdated Show resolved Hide resolved
proposals/NNNN-Avoid-Deadlock.md Outdated Show resolved Hide resolved
Yuki-Shoda-Nexty and others added 11 commits March 13, 2020 14:18
@Yuki-Shoda-Nexty @theresalech
Update proposals/NNNN-Avoid-Deadlock.md
2036a09 
Co-Authored-By: theresalech <theresa@livio.io>
@Yuki-Shoda-Nexty @theresalech
Update proposals/NNNN-Avoid-Deadlock.md
b6c086a 
Co-Authored-By: theresalech <theresa@livio.io>
@Yuki-Shoda-Nexty @theresalech
Update proposals/NNNN-Avoid-Deadlock.md
8707352 
Co-Authored-By: theresalech <theresa@livio.io>
@Yuki-Shoda-Nexty @theresalech
Update proposals/NNNN-Avoid-Deadlock.md
cccb1b2 
Co-Authored-By: theresalech <theresa@livio.io>
@Yuki-Shoda-Nexty @theresalech
Update proposals/NNNN-Avoid-Deadlock.md
478f967 
Co-Authored-By: theresalech <theresa@livio.io>
@Yuki-Shoda-Nexty @theresalech
Update proposals/NNNN-Avoid-Deadlock.md
37518f0 
Co-Authored-By: theresalech <theresa@livio.io>
@Yuki-Shoda-Nexty @theresalech
Update proposals/NNNN-Avoid-Deadlock.md
e1bd460 
Co-Authored-By: theresalech <theresa@livio.io>
@Yuki-Shoda-Nexty @theresalech
Update proposals/NNNN-Avoid-Deadlock.md
e3f15c7 
Co-Authored-By: theresalech <theresa@livio.io>
@Yuki-Shoda-Nexty @theresalech
Update proposals/NNNN-Avoid-Deadlock.md
9702329 
Co-Authored-By: theresalech <theresa@livio.io>
Fixed review issues
e46748b
Merge branch 'Avoid-Deadlock' of github.com:Yuki-Shoda/sdl_evolution …
39cd1e1 
…into Avoid-Deadlock
@Yuki-Shoda-Nexty
Copy link
Contributor Author

Hi @theresalech -san,
Thank you for your review.
I committed all your suggestion.

theresalech
theresalech requested changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@theresalech theresalech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yuki-Shoda there is one last comment that is unresolved. Can you please address? Additionally, please update the description of your PR to only include the following:

This proposal is to avoid deadlock by adding a mechanism that stops Audio Streaming under certain conditions when the app on HS side moves to background.

Please let me know if you have any questions. Thank you!

@Yuki-Shoda-Nexty
Copy link
Contributor Author

Yuki-Shoda-Nexty commented Mar 25, 2020 •
edited

Hi @theresalech -san,
I've changed the "HS" to "Handset (HS)" in the introduction.

@theresalech
Copy link
Contributor

@Yuki-Shoda thank you! Please update the description of your PR to the following:

This proposal is to avoid deadlock by adding a mechanism that stops Audio Streaming under certain conditions when the app on Handset (HS) side moves to background.

All other content currently in your PR description should be removed.

@Yuki-Shoda-Nexty
Copy link
Contributor Author

@theresalech -san
Only the outline was left and other explanations were deleted.

theresalech
theresalech requested changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@theresalech theresalech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yuki-Shoda thank you for updating the PR description! I noticed a few more typos upon further review. Can you please commit my suggestions? I will then mark this PR as review ready. Thank you!

proposals/NNNN-Avoid-Deadlock.md Outdated Show resolved Hide resolved
proposals/NNNN-Avoid-Deadlock.md Outdated Show resolved Hide resolved
proposals/NNNN-Avoid-Deadlock.md Outdated Show resolved Hide resolved
proposals/NNNN-Avoid-Deadlock.md Outdated Show resolved Hide resolved
Yuki-Shoda-Nexty and others added 4 commits March 27, 2020 09:04
@Yuki-Shoda-Nexty @theresalech
Update proposals/NNNN-Avoid-Deadlock.md
bf42f9c 
Co-Authored-By: theresalech <theresa@livio.io>
@Yuki-Shoda-Nexty @theresalech
Update proposals/NNNN-Avoid-Deadlock.md
1b10bff 
Co-Authored-By: theresalech <theresa@livio.io>
@Yuki-Shoda-Nexty @theresalech
Update proposals/NNNN-Avoid-Deadlock.md
2bcc5ac 
Co-Authored-By: theresalech <theresa@livio.io>
@Yuki-Shoda-Nexty @theresalech
Update proposals/NNNN-Avoid-Deadlock.md
477d9a8 
Co-Authored-By: theresalech <theresa@livio.io>
@Yuki-Shoda-Nexty
Copy link
Contributor Author

@theresalech -san,
Thank you for your review.
I committed all your suggestion.

@theresalech theresalech merged commit 638a30e into smartdevicelink:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theresalech theresalech theresalech approved these changes

Assignees
No one assigned
Labels
ios review ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Yuki-Shoda-Nexty @theresalech