ShowAppMenu RPC #2967
Merged
ShowAppMenu RPC #2967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current commit contains brand new RPC "ShowAppMenu". The built-in menu button shows the list of menu entries added with AddCommand. But since this button is hidden for projection apps, the menu is not accessible anymore. So the application should be allowed to send a request to show the built-in menu view. ShowAppMenu RPC allows projection application to send a request to open the built-in app menu or any previously added sub menu by a corresponding id.
ShowAppMenu RPC added to Base-4 and Base-6
Feature/Open Menu RPC
Jack-Byrne
approved these changes
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1937
This PR is ready for review.
Risk
This PR makes major API changes.
Testing Plan
ATF Test scripts
Manual testing with sdl_test_suite
Summary
Adds
ShowAppMenuRPCCLA