[WIP] Initial scripts for Open Menu RPC #2157
Conversation
TMyza
requested review from
GetmanetsIrina,
aderiabin,
dboltovskyi,
HSavynetska and
KrupenichOleg
dboltovskyi
changed the title
| duration = 6000 | ||
| }) | ||
| local AlertId | ||
| EXPECT_HMICALL("UI.Alert", { |
There was a problem hiding this comment.
@TMyza, use common.getHMIConnection():ExpectRequest(...) instead of EXPECT_HMICALL(...)
| position = 500, | ||
| menuName ="SubMenupositive" | ||
| }) | ||
| EXPECT_HMICALL("UI.AddSubMenu", |
There was a problem hiding this comment.
@TMyza, use common.getHMIConnection():ExpectRequest(...) instead of EXPECT_HMICALL(...)
| config.application1.registerAppInterfaceParams.appHMIType = { "PROJECTION" } | ||
|
|
||
| --[[ Local Variables ]] | ||
| local resulCode = "DISALLOWED" |
There was a problem hiding this comment.
@TMyza, please, rename resulCode to resultCode in all scripts.
TMyza
force-pushed
the
feature/open_menu_rpc
branch
from
58c9e1f
to
d10adaf
Compare
| runner.Step("Clean environment", common.preconditions) | ||
| runner.Step("Start SDL, HMI, connect Mobile, start Session", common.start) | ||
| runner.Step("App registration", common.registerApp) | ||
| runner.Step("App activate", common.activateApp) |
There was a problem hiding this comment.
@TMyza Please add info in description of the step that current context is MAIN.
Also for better visibility move this step to Test section.
The same is applicable for 002 and 003 scripts
|
|
||
| function m.showAppMenuSuccess(pMenuID) | ||
| local cid = m.getMobileSession():SendRPC("ShowAppMenu", { menuID = pMenuID }) | ||
| m.getHMIConnection():ExpectRequest("UI.ShowAppMenu", {}) |
There was a problem hiding this comment.
@TMyza Please add check on request's parameters
The same is applicable for showAppMenuHMIwithoutResponse()
| runner.Step("Set HMI SystemContext to MENU" , common.changeHMISystemContext, { "MENU" }) | ||
| runner.Step("Set HMI Level to Limited", common.hmiLeveltoLimited, { 1, "MENU" }) | ||
| runner.Step("Send show App menu, Limited level", common.showAppMenuUnsuccess, { nil, resultCode }) | ||
| runner.Step("Set HMI Level to BACKGROUND", common.deactivateAppToBackground, { "MENU" }) |
There was a problem hiding this comment.
@TMyza According to checklist BACKGROUND HMI level and MENU system context is impossible case
| runner.Step("App activate", common.activateApp) | ||
|
|
||
| runner.Title("Test") | ||
| runner.Step("Send show App menu, SystemContext ALERT", sendAlertSuccess) |
There was a problem hiding this comment.
@TMyza According to checklist ALERT system context has to be verified with FULL, LIMITED and BACKGROUND HMI levels
| @@ -0,0 +1,32 @@ | |||
| --------------------------------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
@TMyza There is a typo in script name HIM
| runner.Title("Test") | ||
| runner.Step("Add menu", common.addSubMenu, { 5 }) | ||
| for _, v in pairs(invalidData) do | ||
| runner.Step("Send show app menu " .. v .. " menuID", common.showAppMenuUnsuccess, { v, resultCode }) |
There was a problem hiding this comment.
@TMyza It would be better to see in step description what kind of invalid data is set. E.g.: string, empty string, float etc.
| common.showAppMenuUnsuccess(nil, resultCode) | ||
| AlertId = data.id | ||
| end) | ||
| common.getHMIConnection():SendResponse(AlertId, "UI.Alert", "SUCCESS", { }) |
There was a problem hiding this comment.
- This response to HMI will be sent before the request to HMI due to asynchronous ATF processing. I suggest to use
RUN_AFTER - Response to mobile is missing
The same is applicable for 012 script
| -- https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0116-open-menu.md | ||
| -- Description: | ||
| -- In case: | ||
| -- 1) Mobile application is set to appropriate HMI level and System Context (see table) |
There was a problem hiding this comment.
@TMyza Since table is not described please provide the list of HMI levels and values for System Context
The same is applicable for 010, 011
TMyza
force-pushed
the
feature/open_menu_rpc
branch
from
edaf078
to
52f2d21
Compare
ATF Test Scripts to check #1937
This PR is not ready for review.
CLA