Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

private_key to wallet_private_key #168

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

naman1402
Copy link

Changed PRIVATE_KEY to WALLET_PRIVATE_KEY in .env.example to avoid confusions.

@naman1402
Copy link
Author

Kindly tag me, for feedback.

@QingyangKong
Copy link
Contributor

Hi @NamanMohnani , why do you want to update PRIVATE_KEY to WALLET_PRIVATE_KEY?

@naman1402
Copy link
Author

Hello @QingyangKong , someone had this issue, and it caused confusion to differentiate it from other key.
https://github.com/smartcontractkit/hardhat-starter-kit/issues/165#issuecomment-1537295956

@QingyangKong
Copy link
Contributor

Can you also check the config file and readme to update the name?

@naman1402
Copy link
Author

hey @QingyangKong I just made another commit as per requirements. Kindly review and give me a feedback and merge, if possible.

Copy link

@nagrarohit nagrarohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NamanMohnani i dont think so , that it is creating any kind of confusion.
May be you should close this request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants