Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename type -> id #13008

Merged
merged 1 commit into from May 2, 2024
Merged

Rename type -> id #13008

merged 1 commit into from May 2, 2024

Conversation

HenryNguyen5
Copy link
Collaborator

@HenryNguyen5 HenryNguyen5 commented Apr 26, 2024 •
edited

This PR contains a commit based on #13061 which will be rebased out when approved.

@HenryNguyen5 HenryNguyen5 force-pushed the chore/KS-167-rename-workflow-tags-to-labels branch 2 times, most recently from ee06a22 to 270fe6b Compare April 30, 2024 00:27
@HenryNguyen5 HenryNguyen5 force-pushed the chore/KS-158-rename-type-to-id branch from c4adf17 to 1da5e47 Compare April 30, 2024 01:20
@HenryNguyen5 HenryNguyen5 requested review from a team as code owners April 30, 2024 03:51
@HenryNguyen5 HenryNguyen5 force-pushed the chore/KS-158-rename-type-to-id branch from b87f3e3 to 7755fc7 Compare April 30, 2024 03:53
@HenryNguyen5 HenryNguyen5 force-pushed the chore/KS-158-rename-type-to-id branch from 7755fc7 to b78cb0b Compare April 30, 2024 03:56
@HenryNguyen5 HenryNguyen5 force-pushed the chore/KS-158-rename-type-to-id branch from df29c0e to 08668fb Compare April 30, 2024 04:33
@HenryNguyen5 HenryNguyen5 requested a review from a team as a code owner April 30, 2024 04:33
@HenryNguyen5 HenryNguyen5 force-pushed the chore/KS-158-rename-type-to-id branch from 08668fb to 80d7a3b Compare April 30, 2024 04:34
@HenryNguyen5 HenryNguyen5 force-pushed the chore/KS-158-rename-type-to-id branch from 7a674c2 to 0e61db2 Compare May 2, 2024 01:29
@HenryNguyen5 HenryNguyen5 requested a review from bolekk May 2, 2024 02:42
@HenryNguyen5 HenryNguyen5 force-pushed the chore/KS-158-rename-type-to-id branch from 29b7cbe to 84fc9f0 Compare May 2, 2024 03:14
@HenryNguyen5 HenryNguyen5 force-pushed the chore/KS-158-rename-type-to-id branch from 84fc9f0 to 1044cb6 Compare May 2, 2024 03:16
@HenryNguyen5 HenryNguyen5 force-pushed the chore/KS-158-rename-type-to-id branch from 1044cb6 to 01ff8fe Compare May 2, 2024 03:19
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
1 Fixed issue
0 Accepted issues

Measures
0 Security Hotspots
84.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@HenryNguyen5 HenryNguyen5 added this pull request to the merge queue May 2, 2024
Merged via the queue into develop with commit 841fe61 May 2, 2024
104 checks passed
@HenryNguyen5 HenryNguyen5 deleted the chore/KS-158-rename-type-to-id branch May 2, 2024 04:54
This was referenced May 2, 2024
Closed
Closed
Closed
davidcauchi pushed a commit that referenced this pull request May 6, 2024
@HenryNguyen5 @davidcauchi
Rename type -> id (#13008)
912f20a
@github-actions github-actions bot mentioned this pull request May 6, 2024
Closed
This was referenced May 6, 2024
Closed
Closed
This was referenced May 8, 2024
Draft
Open
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bolekk bolekk bolekk approved these changes

@archseer archseer Awaiting requested review from archseer archseer is a code owner

@patrick-dowell patrick-dowell Awaiting requested review from patrick-dowell patrick-dowell is a code owner

@DeividasK DeividasK Awaiting requested review from DeividasK

@jmank88 jmank88 Awaiting requested review from jmank88

@RensR RensR Awaiting requested review from RensR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@HenryNguyen5 @DeividasK @jmank88 @bolekk