[BCF-3200] Make sure short tests are actually passing #12989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenryNguyen5
commented
Apr 26, 2024
There was a problem hiding this comment.
Just realized detect-flakey-tests: is almost a full copy/paste of our regular tests... I forgot to update the database URL in there. @kalverra why don't we build the flakey test detection into the ci core test itself?
jmank88
requested changes
Apr 26, 2024
jmank88
reviewed
Apr 26, 2024
HenryNguyen5
force-pushed
the
chore/strict_short_tests
branch
from
2421a7c
to
f2501fa
Compare
jmank88
force-pushed
the
chore/strict_short_tests
branch
from
8b28e94
to
744d986
Compare
HenryNguyen5
force-pushed
the
chore/strict_short_tests
branch
from
9d1504a
to
9c1fbbc
Compare
HenryNguyen5
force-pushed
the
chore/strict_short_tests
branch
from
9c1fbbc
to
57909ad
Compare
HenryNguyen5
force-pushed
the
chore/strict_short_tests
branch
from
57909ad
to
6ca25b4
Compare
HenryNguyen5
changed the title
jmank88
requested changes
Apr 30, 2024
HenryNguyen5
force-pushed
the
chore/strict_short_tests
branch
from
f109b9f
to
bef8ae3
Compare
jmank88
approved these changes
Apr 30, 2024
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.