Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUTO-10236: add integration tests for max gas price check #12974

Merged

Conversation

FelixFan1992
Copy link
Contributor

No description provided.

Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@FelixFan1992 FelixFan1992 marked this pull request as ready for review April 25, 2024 21:00
@FelixFan1992 FelixFan1992 requested review from a team as code owners April 25, 2024 21:00
Base automatically changed from compare-gas-price to pass-gas-estimator April 26, 2024 15:13
@FelixFan1992 FelixFan1992 removed the request for review from a team April 26, 2024 15:19
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@FelixFan1992 FelixFan1992 merged commit 84ae5bf into pass-gas-estimator May 2, 2024
116 of 117 checks passed
@FelixFan1992 FelixFan1992 deleted the add-integration-tests-compare-gas-price branch May 2, 2024 13:18
github-merge-queue bot pushed a commit that referenced this pull request May 6, 2024
…user-defined max gas price in registry 2.1 pipeline (#12952)

* AUTO-10213: pass an gas estimator to registry 2.1 pipeline

* update tests and add changeset

* update changeset

* AUTO-10214: compare max gas price with current gas price in simulation process (#12955)

* AUTO-10214: compare max gas price with current gas price in simulation process

* refactor and add tests

* linting (#12960)

* linting * 2

* fix linting

* create opts with latest block

* AUTO-10236: add integration tests for max gas price check (#12974)

* AUTO-10214: compare max gas price with current gas price in simulation process

* refactor and add tests

* linting (#12960)

* linting * 2

* fix linting

* AUTO-10236

* fix go mod

* update test json

* improve max gas price integration tests

* AUTO-10214: compare max gas price with current gas price in simulation process

* refactor and add tests

* linting (#12960)

* linting * 2

* fix linting

* create opts with latest block

* add some logs

* fix bug and update logs

* update

* update

* update logs

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant