Validate if all required env vars are supplied. #12879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scheibinger
changed the title
chainchad
requested changes
Apr 18, 2024
chainchad
reviewed
Apr 19, 2024
|
|
||
| # Exit with an error if any variables were missing | ||
| if [ $missing_vars -ne 0 ]; then | ||
| echo "Total missing environment variables: $missing_vars" |
There was a problem hiding this comment.
It might not be obvious to someone what vars they need to set from this message. WDYT about printing the $required_vars here or printing the path to the .env.example file?
There was a problem hiding this comment.
good point, I updated the script to print more instructions
…rsch.crib-refactor
Validate if all required env vars are supplied
scheibinger
force-pushed
the
rsch.check-vars
branch
from
47a9f65
to
fe803a1
Compare
chainchad
approved these changes
Apr 24, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate if all required env vars are supplied.
There is a similar PR in the ccip repo already: smartcontractkit/ccip#735