add coverage for registerUpkeep in registrar

smartcontractkit · Apr 26, 2024 · 381b46a · 381b46a
1 parent aab1519
commit 381b46a
Show file tree

Hide file tree

Showing 2 changed files with 80 additions and 0 deletions.
diff --git a/contracts/src/v0.8/automation/dev/test/AutomationRegistrar2_3.t.sol b/contracts/src/v0.8/automation/dev/test/AutomationRegistrar2_3.t.sol
@@ -241,4 +241,80 @@ contract RegisterUpkeep is SetUp {
     vm.expectRevert(AutomationRegistrar2_3.DuplicateEntry.selector);
     registrar.registerUpkeep(params);
   }
+
+  function testLink_revertOnInsufficientPayment() external {
+    vm.startPrank(UPKEEP_ADMIN);
+
+    // slightly less than the minimum amount
+    uint96 amount = uint96(registrar.getMinimumRegistrationAmount(IERC20(address(linkToken))) - 1);
+    linkToken.approve(address(registrar), amount);
+
+    AutomationRegistrar2_3.RegistrationParams memory params = AutomationRegistrar2_3.RegistrationParams({
+      upkeepContract: address(TARGET1),
+      amount: amount,
+      adminAddress: UPKEEP_ADMIN,
+      gasLimit: 10_000,
+      triggerType: 0,
+      billingToken: IERC20(address(linkToken)),
+      name: "foobar",
+      encryptedEmail: "",
+      checkData: bytes("check data"),
+      triggerConfig: "",
+      offchainConfig: ""
+    });
+
+    // attempt to register but revert bc of insufficient payment
+    vm.expectRevert(AutomationRegistrar2_3.InsufficientPayment.selector);
+    registrar.registerUpkeep(params);
+  }
+
+  function testLink_revertOnInvalidAdminAddress() external {
+    vm.startPrank(UPKEEP_ADMIN);
+
+    uint96 amount = uint96(registrar.getMinimumRegistrationAmount(IERC20(address(linkToken))));
+    linkToken.approve(address(registrar), amount);
+
+    AutomationRegistrar2_3.RegistrationParams memory params = AutomationRegistrar2_3.RegistrationParams({
+      upkeepContract: address(TARGET1),
+      amount: amount,
+      adminAddress: ZERO_ADDRESS, // zero address is invalid
+      gasLimit: 10_000,
+      triggerType: 0,
+      billingToken: IERC20(address(linkToken)),
+      name: "foobar",
+      encryptedEmail: "",
+      checkData: bytes("check data"),
+      triggerConfig: "",
+      offchainConfig: ""
+    });
+
+    // attempt to register but revert bc of invalid admin address
+    vm.expectRevert(AutomationRegistrar2_3.InvalidAdminAddress.selector);
+    registrar.registerUpkeep(params);
+  }
+
+  function testLink_revertOnInvalidBillingToken() external {
+    vm.startPrank(UPKEEP_ADMIN);
+
+    uint96 amount = 1;
+    usdToken18_2.approve(address(registrar), amount);
+
+    AutomationRegistrar2_3.RegistrationParams memory params = AutomationRegistrar2_3.RegistrationParams({
+      upkeepContract: address(TARGET1),
+      amount: amount,
+      adminAddress: UPKEEP_ADMIN,
+      gasLimit: 10_000,
+      triggerType: 0,
+      billingToken: IERC20(address(usdToken18_2)), // unsupported billing token
+      name: "foobar",
+      encryptedEmail: "",
+      checkData: bytes("check data"),
+      triggerConfig: "",
+      offchainConfig: ""
+    });
+
+    // attempt to register but revert bc of invalid admin address
+    vm.expectRevert(AutomationRegistrar2_3.InvalidBillingToken.selector);
+    registrar.registerUpkeep(params);
+  }
 }
diff --git a/contracts/src/v0.8/automation/dev/test/BaseTest.t.sol b/contracts/src/v0.8/automation/dev/test/BaseTest.t.sol
@@ -43,6 +43,7 @@ contract BaseTest is Test {
   LinkToken internal linkToken;
   ERC20Mock6Decimals internal usdToken6;
   ERC20Mock internal usdToken18;
+  ERC20Mock internal usdToken18_2;
   WETH9 internal weth;
   MockV3Aggregator internal LINK_USD_FEED;
   MockV3Aggregator internal NATIVE_USD_FEED;
@@ -76,6 +77,7 @@ contract BaseTest is Test {
     linkToken = new LinkToken();
     linkToken.grantMintRole(OWNER);
     usdToken18 = new ERC20Mock("MOCK_ERC20_18Decimals", "MOCK_ERC20_18Decimals", OWNER, 0);
+    usdToken18_2 = new ERC20Mock("Second_MOCK_ERC20_18Decimals", "Second_MOCK_ERC20_18Decimals", OWNER, 0);
     usdToken6 = new ERC20Mock6Decimals("MOCK_ERC20_6Decimals", "MOCK_ERC20_6Decimals", OWNER, 0);
     weth = new WETH9();
 
@@ -128,6 +130,8 @@ contract BaseTest is Test {
     usdToken18.mint(FINANCE_ADMIN, 1000e18);
     usdToken18.mint(STRANGER, 1000e18);
 
+    usdToken18_2.mint(UPKEEP_ADMIN, 1000e18);
+
     usdToken6.mint(OWNER, 1000e6);
     usdToken6.mint(UPKEEP_ADMIN, 1000e6);
     usdToken6.mint(FINANCE_ADMIN, 1000e6);