New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ZkSync methods #714
base: main
Are you sure you want to change the base?
Added ZkSync methods #714
Conversation
smickovskid
commented
Sep 28, 2023
- Added ZkSync methods
I added an override for the funding/refunding logic for zkSync. I wasn't sure whether to opt for duplicating code or changing the existing implementation on
to accept an interface? Thereby we could prevent having the same code twice. |
5f5fd57
to
d2399fb
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #714 +/- ##
==========================================
- Coverage 31.13% 30.24% -0.90%
==========================================
Files 41 42 +1
Lines 5361 5519 +158
==========================================
Hits 1669 1669
- Misses 3512 3670 +158
Partials 180 180 ☔ View full report in Codecov by Sentry. |
a225741
to
700a34c
Compare