Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ZkSync methods #714

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Added ZkSync methods #714

wants to merge 7 commits into from

Conversation

smickovskid
Copy link
Contributor

  • Added ZkSync methods

@friedemannf
Copy link
Member

I added an override for the funding/refunding logic for zkSync. I wasn't sure whether to opt for duplicating code or changing the existing implementation on EthereumClient but chose the former for now.
Maybe it would make more sense for

func attemptReturn(e *EthereumClient, fromKey *ecdsa.PrivateKey, attemptCount int) (*types.Transaction, error)

to accept an interface? Thereby we could prevent having the same code twice.

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2023

Codecov Report

Attention: 158 lines in your changes are missing coverage. Please review.

Comparison is base (368aa75) 31.13% compared to head (a1c6b64) 30.24%.

Files Patch % Lines
blockchain/zksync.go 0.00% 156 Missing ⚠️
blockchain/known_networks.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #714      +/-   ##
==========================================
- Coverage   31.13%   30.24%   -0.90%     
==========================================
  Files          41       42       +1     
  Lines        5361     5519     +158     
==========================================
  Hits         1669     1669              
- Misses       3512     3670     +158     
  Partials      180      180              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants