[WIP] Typed capability API #462
Conversation
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Failure
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
force-pushed
the
typed-capability-api
branch
from
370482a
to
ba3b79c
Compare
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Failure
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
| } | ||
|
|
||
| func (c *capability[I, O, C]) Execute(ctx context.Context, callback chan<- capabilities.CapabilityResponse, request capabilities.CapabilityRequest) error { | ||
| tcb := make(chan CapabilityResponse[O]) |
There was a problem hiding this comment.
I mean obviously it stands for Typed Capability Response :P
| } | ||
| } | ||
|
|
||
| func NewCapability[I, O, C any](cap Capability[I, O, C]) capabilities.CallbackExecutable { |
There was a problem hiding this comment.
This looks great, and is the direction I wanted to take the Validation API efforts to :)
What we're building represents a RPC framework of sorts.
I'd imagine there's a lot of value to be had by allowing the user to inject middlewares that are called during request/response lifecycle
There was a problem hiding this comment.
Yes agreed :) We could use this for observability and logging for example :)
| Err error | ||
| } | ||
|
|
||
| type CapabilityRequest[I, C any] struct { |
There was a problem hiding this comment.
How do those work in a remote setting? Does the receiver always know what type to expect or is there some type info encoded too?
There was a problem hiding this comment.
I'd imagine it's the same, capabilities should have a input/config/output schema they abide to.
There was a problem hiding this comment.
@bolekk This is purely a client-side feature (i.e. inside the capability), anything accessing the capability (either via the Remote API or via the workflow engine would continue to do so via the lower-level, values-based API.
No description provided.