pkg/sqlutil/pg: create package; expand env config #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmank88
commented
Apr 17, 2024
krehermann
reviewed
Apr 17, 2024
pkg/loop/config.go
Outdated
| @@ -150,3 +196,27 @@ func getDatabaseURL() (*url.URL, error) { | |||
| } | |||
| return u, nil | |||
| } | |||
|
|
|||
| func getDatabaseIdleInTxSessionTimeout() (time.Duration, error) { | |||
| return time.ParseDuration(os.Getenv(envDatabaseDefaultIdleInTxSessionTimeout)) | |||
There was a problem hiding this comment.
do these need default values? if i'm reading the code correctly, i think this will error if the env vars aren't set? are we assuming that the core node sets them? if so, i think we need a comment somewhere in this repo, probably where they are defined, and a test integration test to ensure all the value are coming through the env correctly
There was a problem hiding this comment.
They are only required if the DB URL is included. Yeah the dummy plugin on the core side is meant to address it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports: