update metis naming #30
Conversation
Co-authored-by: André Vitor de Lima Matos <andre.vmatos@gmail.com>
There was a problem hiding this comment.
Hey folks, we want chain-selectors to be the source of the truth for names. Therefore RDD should rely on values from here, not the other way around. What is more, a chain is named metis everywhere, so I don't believe switching to Andromeda is a good idea. I believe readme contains all the necessary information on how to build a proper name
| @@ -135,7 +135,7 @@ selectors: | |||
| name: "ethereum-mainnet-kroma-1" | |||
| 1088: | |||
| selector: 8805746078405598895 | |||
| name: "ethereum-mainnet-metis-1" | |||
| name: "ethereum-mainnet-andromeda-1" | |||
There was a problem hiding this comment.
OK, this is just wrong; Everyone calls this network Metis, even https://l2fees.info/.
Calling it "Andromeda" is like renaming Ethereum to homestead-mainnet.
chain-selectors is supposed to be the gate-keeper of proper naming convention. We shouldn't compromise here. RDD is internal, and can always rename later. And it should have the names registered here before pushing it elsewhere. We promise quick reviews.
There was a problem hiding this comment.
There was a situation with gnosis recently where we named it correctly in chain-selectors but in RDD it had been named "xdai mainnet" since we integrated with that chain a long time ago. Same situation with Metis.
Will make a note for eng-ops that the naming will be different for metis and see what the lift is to sync rdd with chain-selectors.
Updating to be consistent with RDD